New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maxFiles issue when added files from server #2003
base: main
Are you sure you want to change the base?
Conversation
oe, nice; this would probably fix #2031 :) |
Olá boa tarde preciso exatamente dessa correção quando será realizado o merge ? Obrigado! |
+1 - Works as expected. In the meantime, the method can be overridden in a custom JS file: const instance = new Dropzone(element, settings);
const { displayExistingFile } = instance;
instance.displayExistingFile = function (mockFile, imageUrl, callback, crossOrigin, param) {
displayExistingFile.call(this, mockFile, imageUrl, callback, crossOrigin, param);
// @see https://github.com/dropzone/dropzone/pull/2003
mockFile.accepted = true;
mockFile.status = Dropzone.SUCCESS;
this.files.push(mockFile);
this._updateMaxFilesReachedClass();
}; |
@robphillips Maybe dumb question here but, where does the local variable "file" come from in your custom displayExistingFile function? |
Whoops! Typo. Updated. |
I used the Dropzone source code to come up with what was missing when adding existing files (we were previously reducing maxFiles which had much the same effect unless you tried to remove/add when it got quite confused); after doing that, I then discovered a PR on Dropzone which has the same fixes: dropzone/dropzone#2003
I used the Dropzone source code to come up with what was missing when adding existing files (we were previously reducing maxFiles which had much the same effect unless you tried to remove/add when it got quite confused); after doing that, I then discovered a PR on Dropzone which has the same fixes: dropzone/dropzone#2003
I used the Dropzone source code to come up with what was missing when adding existing files (we were previously reducing maxFiles which had much the same effect unless you tried to remove/add when it got quite confused); after doing that, I then discovered a PR on Dropzone which has the same fixes: dropzone/dropzone#2003
I used the Dropzone source code to come up with what was missing when adding existing files (we were previously reducing maxFiles which had much the same effect unless you tried to remove/add when it got quite confused); after doing that, I then discovered a PR on Dropzone which has the same fixes: dropzone/dropzone#2003
I used the Dropzone source code to come up with what was missing when adding existing files (we were previously reducing maxFiles which had much the same effect unless you tried to remove/add when it got quite confused); after doing that, I then discovered a PR on Dropzone which has the same fixes: dropzone/dropzone#2003
Any hope for this going live anytime soon? 👀 🙏 |
Files added by displayExistingFiles are not counted to files limit when maxFiles is set.