Emit all files from directories to addedfiles
event
#1995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you drop a directories into the dropzone, you currently only get the files by the
addedfile
event. Theaddedfiles
event instead provides at the moment a corrupt file which represents the root directory which you dropped in.In our project we're disabling dropzone's direct upload and handle the upload and the file handling internally. Therefore we have to know how many files got dropped in total and we can't find this out by the
addedfile
event cause of we never know what's the last file of the queue.As the directory reader only works with callback methods, I wrapped the necessary parts in Promises to wait for the complete queue until I emit the
addedfiles
event. I know that you have browser support for older browsers which do not support Promises but I think in these specific parts of the code it should be okay cause old browsers do not enter these methods as there is the if condition in line634
which asks forwebkitGetAsEntry
. I hope you like my solution.