Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing sites to be nested in other sites #254

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allowing sites to be nested in other sites #254

wants to merge 4 commits into from

Conversation

rmhasan
Copy link
Contributor

@rmhasan rmhasan commented Jan 13, 2017

This is a PR for #215. This PR allows Sites to be nested in other sites. I performed the following tests. I also created a pull request for pynsot that allows users to pass the id of the parent site. The command line argument for passing the parent id is -p

EDIT:
I made the pull request dropbox/pynsot#124

$ nsot sites add -n first
# site with name 'first' is added

$ nsot sites add -n second -p 1
# site with name 'second' is added and its parent is 1

$ nsot sites remove -i 1
# site was not removed, because it is second sites parent

$ nsot sites update -i 1 -p 1
# fails because a site cannot be nested in itself

$ nsot sites add -n third -p 2
$ nsot sites add -n fourth -p 3
$ nsot sites add -n fifth -p 4
$ nsot sites update -i 1 -p 5
# update fails because site with id 5 is a child or grand child of site with id 1

@rmhasan rmhasan changed the title Fix for #215: Allowing sites to be nested in other sites PR for #215: Allowing sites to be nested in other sites Jan 13, 2017
@rmhasan rmhasan changed the title PR for #215: Allowing sites to be nested in other sites PR for #215 : Allowing sites to be nested in other sites Jan 13, 2017
@rmhasan rmhasan changed the title PR for #215 : Allowing sites to be nested in other sites PR for #215: Allowing sites to be nested in other sites Jan 13, 2017
@rmhasan rmhasan changed the title PR for #215: Allowing sites to be nested in other sites Allowing sites to be nested in other sites Jan 13, 2017
@jathanism
Copy link
Contributor

@rmhasan Thanks for this contribution, too! Me and the other maintainers will be taking a look and try to keep this conversation going.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants