Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable feature request #218

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Iterable feature request #218

wants to merge 35 commits into from

Conversation

termlen0
Copy link

Not too sure of the etiquette here :), but I have modified model, serializer and view to allow the creation of two tables : Iterable and IterValue. This enables automation users, to use NSoT as a stateful backend, to keep track of integers (that need auto increments - like vlan numbers, port-channel numbers, cryptomap numbers, tenant IDs etc). That way, any CRUD actions impacting the automated service is tracked and updated as needed.

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove the bin directory
  • Please remove the share directory
  • Why did you remove the nsot/migrations directory? We do need those. I can help you create new migrations for the changes you've made to nsot/models.py

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better!

Please remove the include directory.

@jathanism
Copy link
Contributor

@termlen0 It's been a bit since I've gotten back to you on this PR, but I still think it's very important! I have some ideas. Stay tuned!

@wasabi222
Copy link

checking in on the status of this one :)

@termlen0
Copy link
Author

checking in on the status of this one :)

:) I haven't used NSoT now in at least 2 years. I should probably close this PR since the project must have moved on. I'd reach out to @jathanism to check of similar functionality already implemented.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants