feat: improve environment support #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve support for configuring the tool from the environment as is commonly used for CI use cases. This adds the ability to read auth tokens from the DROPBOX_TOKENS environment variable instead of from the configuration file. Also add the ability to configured the personal app key which wasn't named and now configurable using DROPBOX_PERSONAL_APP_KEY environment variable to match the other options. Constants for config location and environment variable names are now stored in consts.go to make them more visible. Some additional improvement in error checking and extracting the common configFile helper, including using stdlib os.UserHomeDir instead of the custom library version. Switch from deprecated ioutil.ReadFile to supported os.ReadFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for configuring the tool from the environment as is commonly used for CI use cases.
This adds the ability to read auth tokens from the DROPBOX_TOKENS environment variable instead of from the configuration file.
Also add the ability to configured the personal app key which wasn't named and now configurable using DROPBOX_PERSONAL_APP_KEY environment variable to match the other options.
Constants for config location and environment variable names are now stored in consts.go to make them more visible.
Some additional improvement in error checking and extracting the common configFile helper, including using stdlib os.UserHomeDir instead of the custom library version.
Switch from deprecated ioutil.ReadFile to supported os.ReadFile.