Add timeout option to the shell:exec command.

droid-php · Sep 23, 2016 · eaac7c5 · eaac7c5
1 parent 8b026b4
commit eaac7c5
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/src/Command/ShellExecCommand.php b/src/Command/ShellExecCommand.php
@@ -4,6 +4,7 @@
 
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Process\ProcessBuilder;
 use Symfony\Component\Console\Input\InputArgument;
@@ -22,12 +23,19 @@ public function configure()
     {
         $this
             ->setName('shell:exec')
-            ->setDescription('Initiate a reboot.')
+            ->setDescription('Execute the given command line in Bash.')
             ->addArgument(
                 'command-line',
                 InputArgument::REQUIRED,
                 'The command and arguments to be executed by the shell.'
             )
+            ->addOption(
+                'timeout',
+                't',
+                InputOption::VALUE_REQUIRED,
+                'The maximum permitted execution time in seconds.',
+                60
+            )
         ;
     }
 
@@ -38,7 +46,8 @@ public function execute(InputInterface $input, OutputInterface $output)
                 'bash',
                 '-c',
                 $input->getArgument('command-line')
-            )
+            ),
+            $input->getOption('timeout')
         );
 
         if ($p->run()) {
@@ -58,11 +67,12 @@ public function execute(InputInterface $input, OutputInterface $output)
     /**
      * @return \Symfony\Component\Process\Process
      */
-    private function getProcess($arguments)
+    private function getProcess($arguments, $timeout)
     {
         return $this
             ->processBuilder
             ->setArguments($arguments)
+            ->setTimeout($timeout)
             ->getProcess()
         ;
     }