[Base] Add filter to get current env #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be implemented as a model? @loetie @robvandenbogaard |
robvandenbogaard
requested changes
Apr 23, 2020
There was a problem hiding this comment.
Agreed with @rl-king that this should be a model, not a filter - an indication is that the filter parameter is dropped; it doesn't filter anything. Should the model be m.environment or would that pollute the global model namespace too much (vs m.system.environment or m.server.environment - is there already a namespace/model we can extend for this)?
rl-king
reviewed
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A filter to get the current environment to use in the templates.