Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing an array to the constructor so we can configure the timeout #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow passing an array to the constructor so we can configure the timeout #276

wants to merge 1 commit into from

Conversation

driade
Copy link

@driade driade commented Jul 1, 2019

No description provided.

@drewm
Copy link
Owner

drewm commented Jul 4, 2019

Thinking about this further, if we're adding $parameters to the contractor, would it not make more sense to add $parameters to the method calls too? Rather than just $timeout?

@driade
Copy link
Author

driade commented Jul 4, 2019

It totally makes sense but, then, isn't it breaking change? I wasn't sure if you think that's ok.

In my opinion I'd in fact remove that option from the method calls, and let the user the option to "configure" all the possible parameters (ssl, timeout) via the constructor / an additional settter.

@driade
Copy link
Author

driade commented Oct 1, 2020

Let's see if it's finally accepted! I'd update the documentation if it's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants