Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render-engine): hyphenation in paragraph layout #2172

Merged
merged 15 commits into from
May 14, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented May 7, 2024

close #2201

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 45.26627% with 185 lines in your changes are missing coverage. Please review.

Project coverage is 30.84%. Comparing base (b51d22e) to head (6d0a9b4).
Report is 14 commits behind head on dev.

Files Patch % Lines
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 64 Missing ⚠️
.../components/docs/layout/block/paragraph/shaping.ts 0.00% 34 Missing ⚠️
...nts/docs/layout/block/paragraph/line-adjustment.ts 0.00% 15 Missing ⚠️
...nents/docs/layout/hyphenation/language-detector.ts 0.00% 12 Missing ⚠️
...r/src/components/docs/layout/hyphenation/hyphen.ts 93.50% 5 Missing ⚠️
...c/components/docs/layout/block/paragraph/layout.ts 0.00% 2 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 2 Missing ⚠️
...onents/docs/layout/block/paragraph/linebreaking.ts 0.00% 1 Missing ⚠️
.../components/docs/layout/hyphenation/patterns/as.ts 0.00% 1 Missing ⚠️
.../components/docs/layout/hyphenation/patterns/be.ts 0.00% 1 Missing ⚠️
... and 48 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2172      +/-   ##
==========================================
+ Coverage   30.80%   30.84%   +0.04%     
==========================================
  Files        1274     1358      +84     
  Lines       70107    70614     +507     
  Branches    14774    14855      +81     
==========================================
+ Hits        21599    21784     +185     
- Misses      48508    48830     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Jocs Jocs changed the title feat(render-engine): hyphenation paragraph layout feat(render-engine): hyphenation in paragraph layout May 9, 2024
@Jocs Jocs marked this pull request as ready for review May 11, 2024 09:51
@Jocs Jocs requested review from jikkai, wzhudev and DR-Univer and removed request for lumixraku, wzhudev and DR-Univer May 11, 2024 09:51
@oumomomo oumomomo added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label May 14, 2024
@Jocs Jocs merged commit 2739fba into dev May 14, 2024
9 checks passed
@Jocs Jocs deleted the feat/hyphenation branch May 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Ticket] Hyphenation in paragraph text layout
3 participants