Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): image feature develop #1972

Closed
wants to merge 24 commits into from
Closed

feat(image): image feature develop #1972

wants to merge 24 commits into from

Conversation

DR-Univer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 4.70370% with 2573 lines in your changes are missing coverage. Please review.

Project coverage is 30.01%. Comparing base (3e02de5) to head (be91df6).
Report is 36 commits behind head on dev.

❗ Current head be91df6 differs from pull request most recent head 7150b9b. Consider uploading reports for the commit 7150b9b to get more accurate results

Files Patch % Lines
packages/engine-render/src/scene.transformer.ts 0.00% 547 Missing ⚠️
...mage-ui/src/controllers/image-update.controller.ts 0.00% 222 Missing ⚠️
...re/src/services/drawing/drawing-manager.service.ts 4.97% 172 Missing ⚠️
...age-ui/src/controllers/image-cropper.controller.ts 0.00% 152 Missing ⚠️
...es/image-ui/src/views/crop/image-cropper-object.ts 0.00% 133 Missing ⚠️
...i/src/controllers/sheet-image-update.controller.ts 0.00% 127 Missing ⚠️
...ckages/image-ui/src/views/panel/ImageTransform.tsx 0.00% 125 Missing ⚠️
packages/engine-render/src/shape/image.ts 0.00% 122 Missing ⚠️
...ages/docs-ui/src/controllers/drawing.controller.ts 0.00% 72 Missing ⚠️
...ages/image-ui/src/views/panel/ImageCommonPanel.tsx 0.00% 67 Missing ⚠️
... and 82 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1972      +/-   ##
==========================================
- Coverage   30.75%   30.01%   -0.74%     
==========================================
  Files        1272     1328      +56     
  Lines       70174    72260    +2086     
  Branches    14801    15153     +352     
==========================================
+ Hits        21581    21691     +110     
- Misses      48593    50569    +1976     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer force-pushed the feat-image-1 branch 4 times, most recently from 7a41ab3 to e635a19 Compare April 30, 2024 15:56
@DR-Univer DR-Univer force-pushed the feat-image-1 branch 4 times, most recently from ebdf376 to ce0c0ed Compare May 9, 2024 17:24
@DR-Univer DR-Univer marked this pull request as ready for review May 10, 2024 11:23
@DR-Univer DR-Univer requested a review from ybzky as a code owner May 14, 2024 12:20
@DR-Univer DR-Univer closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants