fix(editor): add valid attribute #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
|
@Gggpound 范围选择器不感知具体表格，需要你在外部判断，然后传参到rangeSelector内部。 |
@Gggpound The range selector is not aware of the specific table. You need to judge externally and then pass the parameters to the rangeSelector internally. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1730 +/- ##
==========================================
- Coverage 31.78% 30.44% -1.34%
==========================================
Files 1041 1213 +172
Lines 57853 74660 +16807
Branches 12165 17161 +4996
==========================================
+ Hits 18387 22730 +4343
- Misses 39466 51930 +12464 ☔ View full report in Codecov by Sentry. |
Gggpound
approved these changes
Mar 28, 2024
zhaolixin7
added
the
qa:verified
wzhudev
reviewed
Apr 13, 2024
| @@ -236,6 +240,10 @@ export function TextEditor(props: ITextEditorProps & Omit<MyComponentProps, 'onC | |||
| editorService.setValueNoRefresh(value, id); | |||
| }, [value]); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
这里不用 useMemo 计算出 validation visble？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx, #yyy, #zzzz