Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Rewrite config #105

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DNM] Rewrite config #105

wants to merge 1 commit into from

Conversation

ZhiyuanChen
Copy link

@ZhiyuanChen ZhiyuanChen commented Mar 2, 2023 •
edited

#104

Please DO NOT MERGE until all TODOs in #104 are addressed.

@ZhiyuanChen ZhiyuanChen force-pushed the config branch 2 times, most recently from a090118 to 5646303 Compare March 2, 2023 18:32
@ZhiyuanChen ZhiyuanChen marked this pull request as draft March 2, 2023 18:34
@ZhiyuanChen ZhiyuanChen changed the title Rewrite config [DNM] Rewrite config Mar 2, 2023
@ZiyaoLi
Copy link
Member

ZiyaoLi commented Mar 3, 2023

please add a test for config dicts of all model names before and after refracture.

@ZhiyuanChen
rewrite config
16bf708 
Signed-off-by: Zhiyuan Chen <this@zyc.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZhiyuanChen @ZiyaoLi