Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 11243 TreeNodeCollection.AddRange has been broken in .NET 8… #11356

Merged
merged 2 commits into from May 23, 2024

Conversation

Epica3055
Copy link
Member

@Epica3055 Epica3055 commented May 11, 2024

Fixes #11243

Screenshots

Before

image

After

image

Test methodology

  • manually and unit test

… and no longer results in TreeNodes being drawn at the correct location
@Epica3055 Epica3055 marked this pull request as ready for review May 11, 2024 07:36
@Epica3055 Epica3055 requested a review from a team as a code owner May 11, 2024 07:36
@Epica3055 Epica3055 removed the draft draft PR label May 11, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label May 13, 2024
@Olina-Zhang
Copy link
Member

Tested this PR based on .NET 8.0, GH issue: #11243 is fixed. And did Accessibility testing in Inspect and Narrator, no change compared with .NET 7.0, no regression issue found.

@Olina-Zhang Olina-Zhang removed the 📬 waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label May 13, 2024
@Tanya-Solyanik Tanya-Solyanik added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label May 13, 2024
@Epica3055 Epica3055 added the Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria label May 14, 2024
@Tanya-Solyanik Tanya-Solyanik added Servicing-approved .NET Shiproom approved the PR for merge and removed Servicing-consider .NET Shiproom label indicating a PR seeks to enter into a branch under Tell-Mode criteria labels May 14, 2024
@lonitra
Copy link
Member

lonitra commented May 22, 2024

Looks like branding occured a few days ago. @Tanya-Solyanik double checking here -- is this good to merge now?

@Tanya-Solyanik Tanya-Solyanik merged commit 247e021 into dotnet:release/8.0 May 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) Servicing-approved .NET Shiproom approved the PR for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants