New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for DomainUpDown #11331
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11331 +/- ##
===================================================
+ Coverage 74.22320% 74.27404% +0.05083%
===================================================
Files 3021 3025 +4
Lines 626156 626857 +701
Branches 46698 46742 +44
===================================================
+ Hits 464753 465592 +839
+ Misses 158006 157920 -86
+ Partials 3397 3345 -52
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DomainUpDownTests.cs
Show resolved
Hide resolved
LGTM! @lonitra Please review this PR. |
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DomainUpDownTests.cs
Outdated
Show resolved
Hide resolved
Assert.True(control.CanRaiseEvents); | ||
Assert.True(control.CausesValidation); | ||
Assert.False(control.ChangingText); | ||
Assert.Null(_sub.ActiveControl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fluent assertions.
related #10453
Proposed changes
Customer Impact
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow