New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nullability in some ControlDesigner members #11285
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11285 +/- ##
===================================================
+ Coverage 74.26878% 74.27201% +0.00322%
===================================================
Files 3025 3025
Lines 626861 626866 +5
Branches 46742 46743 +1
===================================================
+ Hits 465562 465586 +24
+ Misses 157959 157937 -22
- Partials 3340 3343 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid using abbreviations
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ControlDesigner.cs
Outdated
Show resolved
Hide resolved
96861aa
to
251c916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Microsoft Reviewers: Open in CodeFlow