Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullability in TabPageCollectionEditor #11283

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Apr 28, 2024

Proposed changes

  • Enable nullability in TabPageCollectionEditor.
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 74.32392%. Comparing base (b95d01b) to head (fab2943).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11283         +/-   ##
===================================================
+ Coverage   74.32164%   74.32392%   +0.00227%     
===================================================
  Files           3028        3028                 
  Lines         627287      627296          +9     
  Branches       46765       46767          +2     
===================================================
+ Hits          466210      466231         +21     
+ Misses        157729      157719         -10     
+ Partials        3348        3346          -2     
Flag Coverage Δ
Debug 74.32392% <37.50000%> (+0.00227%) ⬆️
integration 17.99491% <0.00000%> (-0.00162%) ⬇️
production 47.08476% <37.50000%> (+0.00589%) ⬆️
test 96.98888% <ø> (ø)
unit 44.06018% <37.50000%> (+0.00458%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Apr 28, 2024
Copy link
Member

@Epica3055 Epica3055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 😁

@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Apr 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 1, 2024
@gpetrou gpetrou requested a review from lonitra May 1, 2024 05:03
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 1, 2024
@lonitra lonitra added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 3, 2024
@gpetrou gpetrou requested a review from lonitra May 15, 2024 12:59
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 15, 2024
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 15, 2024
Comment on lines 116 to 125
object? o = TypeDescriptor.CreateInstance(host, itemType, argTypes: null, args: null);

return o is null
? throw new InvalidOperationException(
string.Format(
SR.CollectionEditorCreateInstanceError,
nameof(IDesignerHost),
nameof(TypeDescriptor),
itemType.FullName))
: o;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using is {} obj can more simpler

      if (TypeDescriptor.CreateInstance(host, itemType, argTypes: null, args: null) is { } obj)
      {
          return obj;
      }

      throw new InvalidOperationException(
          string.Format(
          SR.CollectionEditorCreateInstanceError,
          nameof(IDesignerHost),
          nameof(TypeDescriptor),
          itemType.FullName));

@LeafShi1 LeafShi1 added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 17, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants