Code cleanup only

[paul1956]

Fixes part of #10090
Standalone PR to do some cleanup of VB Code
Removes VB Option from source files and moves to Project File
Correct Spelling and Capitalization Errors
Add a few tests
Update editorConfig to support converting 3 NotInheritable classes to Modules.
Add a few tests
Change format of XLM Comment to indent text by 1 space
Change a few Private functions to Friend for testing
Not all issues are addressed in files I expect to replace.
Not done is reorganizing code in files to be in standard order, this will be a follow-on PR

Proposed changes

Fix above with very minimal code changes

Customer Impact

• None only developers will notice

Regression?

No

Risk

• Minimal due to almost no code changes

Test methodology

Added tests where required otherwise covered by existing tests

Visual Basic only

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 92.27882% with 144 lines in your changes are missing coverage. Please review.

Project coverage is 74.45001%. Comparing base (9014e59) to head (10b611b).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11215         +/-   ##
===================================================
+ Coverage   74.28888%   74.45001%   +0.16113%     
===================================================
  Files           3026        3040         +14     
  Lines         627075      628560       +1485     
  Branches       46755       46781         +26     
===================================================
+ Hits          465847      467963       +2116     
+ Misses        157882      157239        -643     
- Partials        3346        3358         +12     

Flag	Coverage Δ
Debug	74.45001% <92.27882%> (+0.16112%)	⬆️
integration	17.99273% <16.99164%> (-0.00198%)	⬇️
production	47.24823% <61.00279%> (+0.22216%)	⬆️
test	96.99916% <99.73440%> (+0.01216%)	⬆️
unit	44.24741% <48.46797%> (+0.24531%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[paul1956]

@KlausLoeffelmann can you get someone assigned to review please. This consolidates much of the cleanup and adds testing to VB code. Some files are not touched as they require code changes covered in other PR's.

[lonitra]

Appreciate your patience here @paul1956! @KlausLoeffelmann is preparing for BUILD talk this week, but will take a look at your PRs afterwards

[paul1956]

Ping @lonitra @KlausLoeffelmann @JeremyKuhne Any update on Review timing?

[KlausLoeffelmann]

We just finished BUILD and some immediate security issues and need to regroup now.
I have something VB related coming up in this context in the next days, which is a higher priority.
I'll ping you with it once I have a draft.