Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unimplemented types for deprecated UI controls #10913

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

SimonZhao888
Copy link
Member

@SimonZhao888 SimonZhao888 commented Feb 20, 2024

Fixes #3783

Proposed changes

  • Adding Deprecated Controls Back to .NET9
  • Add PlatformNotSupportedException exceptions to all the public method property of the deprecated controls
  • Add [Browsable(false), EditorBrowsable(EditorBrowsableState.Never)] attributes to all the public properties.
  • Add [Obsolete("ContextMenu has been deprecated. Use ContextMenuStrip instead.")] to all the deprecated controls

Test methodology

  • manually
  • WinformsControlTest

Test environment(s)

  • 9.0.0-preview.2.24120.8
Microsoft Reviewers: Open in CodeFlow

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Mar 1, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Mar 5, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 1.66521% with 1122 lines in your changes are missing coverage. Please review.

Project coverage is 73.31842%. Comparing base (6710618) to head (cf386e6).
Report is 76 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10913         +/-   ##
===================================================
- Coverage   73.44496%   73.31842%   -0.12654%     
===================================================
  Files           3097        3122         +25     
  Lines         632155      633362       +1207     
  Branches       46653       46660          +7     
===================================================
+ Hits          464286      464371         +85     
- Misses        164469      165597       +1128     
+ Partials        3400        3394          -6     
Flag Coverage Δ
Debug 73.31842% <1.66521%> (-0.12654%) ⬇️
integration 18.30607% <0.00000%> (-0.05976%) ⬇️
production 46.76045% <0.00000%> (-0.15391%) ⬇️
test 94.93400% <8.96226%> (-0.05098%) ⬇️
unit 43.73995% <0.00000%> (-0.14366%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@SimonZhao888 SimonZhao888 marked this pull request as ready for review March 11, 2024 08:24
@SimonZhao888 SimonZhao888 requested a review from a team as a code owner March 11, 2024 08:24
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Mar 11, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label Mar 12, 2024
@SimonZhao888 SimonZhao888 force-pushed the Issue_3783_AddUnimplementedTypeForObsoleteControls branch from 287033f to 8dc151f Compare April 2, 2024 01:56
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 2, 2024
@ricardobossan
Copy link
Contributor

LGTM

@Tanya-Solyanik Tanya-Solyanik added waiting-review This item is waiting on review by one or more members of team waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unimplemented types for deprecated UI controls
5 participants