Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System.Security.Cryptography.Xml.8.0.0 to address CVE-2023-29331 #944

Merged

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Apr 24, 2024

A pre-req for dotnet/aspnetcore#55304

@RussKie
Copy link
Member Author

RussKie commented Apr 24, 2024

@MichaelSimons @mthalman I've run PS > .\generate.cmd -package System.Security.Cryptography.Xml,8.0.0 and this is the result.
The docs state that the new projects need to be added to https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props, but I've searched the repo and I didn't see the original System.Security.Cryptography.Xml.6.0.1.csproj project being referenced anywhere (did I miss it?).

Is there anytything else I need to do?

@oleksandr-didyk
Copy link
Contributor

but I've searched the repo and I didn't see the original System.Security.Cryptography.Xml.6.0.1.csproj project being referenced anywhere (did I miss it?).

The required entry in Build.props is for the package being added and not meant as an update to existing references. Unless I miss-understood your comment.

So its just about putting:

  <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Security.Cryptography.Xml.8.0.0.csproj" />

@RussKie
Copy link
Member Author

RussKie commented Apr 24, 2024

May I please get help with the build errors?

@oleksandr-didyk
Copy link
Contributor

Of course, taking a look

@oleksandr-didyk
Copy link
Contributor

Those look like compilation errors for the package being added, i.e. there are probably some manual changes that need to be made to resolve them. Is the build passing locally for you?

@mthalman mthalman merged commit 962890b into dotnet:main Apr 29, 2024
4 checks passed
@RussKie RussKie deleted the bump_System.Security.Cryptography.Xml_version branch April 29, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants