Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case for unsuccessful custom analyzer registration + change e2e tests #10117

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented May 7, 2024

Fixes

The case, mentioned in documentation: #10078 (comment) and build CustomAnalyzer test assets during the build to reduce the test running time.

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear how this can happen.
As if I'd receive such error as a user - I'd be probably very confused (as the type satisfies first condition)

src/Build/Resources/Strings.resx Outdated Show resolved Hide resolved
src/Build/Resources/Strings.resx Outdated Show resolved Hide resolved
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to go!

src/Build/Resources/Strings.resx Outdated Show resolved Hide resolved
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
@YuliiaKovalova YuliiaKovalova changed the title Handle the case for unsuccessful custom analyzer registration Handle the case for unsuccessful custom analyzer registration + change e2e tests May 23, 2024
@YuliiaKovalova YuliiaKovalova force-pushed the dev/ykovalova/handle_invalidBaseClassCase branch 2 times, most recently from 0456a67 to 536f139 Compare May 24, 2024 10:42
@YuliiaKovalova YuliiaKovalova force-pushed the dev/ykovalova/handle_invalidBaseClassCase branch from b92bad4 to bdc4a33 Compare May 24, 2024 13:52
@YuliiaKovalova YuliiaKovalova merged commit 0b3caf7 into dotnet:main May 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants