New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the case for unsuccessful custom analyzer registration + change e2e tests #10117
Handle the case for unsuccessful custom analyzer registration + change e2e tests #10117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unclear how this can happen.
As if I'd receive such error as a user - I'd be probably very confused (as the type satisfies first condition)
src/Build/BuildCheck/Acquisition/BuildCheckAcquisitionModule.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to go!
Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
0456a67
to
536f139
Compare
b92bad4
to
bdc4a33
Compare
Fixes
The case, mentioned in documentation: #10078 (comment) and build CustomAnalyzer test assets during the build to reduce the test running time.