Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null in list of warnings or errors in SDK result #10094

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Null in list of warnings or errors in SDK result #10094

wants to merge 1 commit into from

Conversation

rokonec
Copy link
Contributor

@rokonec rokonec commented May 2, 2024

Fixes partially #9537

Context

Customer reported error caused by SDK resolver returning null in list of message. This can be caused by customer or 3rd party SDK resolver, so additional diagnostics and robustness can help here.

Changes Made

  • diagnostic message when this happens
  • ignoring null or empty warnings

Testing

locally

Notes

@rokonec rokonec changed the title Comment for null ás warning or error in SDK result Null in list of warnings or errors in SDK result May 2, 2024
AR-May
AR-May approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we consider adding some tests with the sdk resolver which throw null as error/warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@AR-May AR-May AR-May approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rokonec @rainersigwald @AR-May