Update scheduling-threads.md added an example code #40739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an example code with description.
dotnet-policy-service
bot
added
the
community-contribution
|
@dotnet-policy-service agree |
BillWagner
requested changes
May 3, 2024
There was a problem hiding this comment.
Hi @victoravt
This is an important sample to add. Thank you.
I had a few comments for updates, and then this is ready to merge.
|
|
||
| The following code will output arbitrary results on each execution. But common sequence patters of priorities being ran could be observed after running multiple times and analyzing the outputs. | ||
|
|
||
| ```c# |
There was a problem hiding this comment.
For samples, we've been moving toward including samples as code files using the ::: code extension. That enables our CI system to validate the code. Can you move the sample code into a project and include the code here?
Comment on lines
+48
to
+56
| Thread t0 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t1 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t2 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t3 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t4 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t5 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t6 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t7 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); | ||
| Thread t8 = new Thread(() => { new ThreadWithCallback(Callback).Process(); }); |
There was a problem hiding this comment.
There's a log of opportunity to refactor this so it's got less repeated code. Maybe store the threads in an array and loop through the creation, setting priority, and start code?
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The example demonstrates the prioritization of threads in action and gives code base for readers to copy and experiment with.
Describe your changes here.
Added an example code with description.
Fixes #Issue_Number (if available)
No issue.
Internal previews