Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing registry keys for Microsoft.AspNetCore.App #55467

Merged
merged 7 commits into from May 2, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 1, 2024

Should fix #55368. If it works we should backport to 6.0 & 80

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2442651&view=results

@wtgodbe wtgodbe requested a review from joeloff May 1, 2024 20:51
@wtgodbe wtgodbe requested a review from a team as a code owner May 1, 2024 20:51
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 1, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented May 2, 2024

Tested this out & it sets the registry key when installing the SharedFx, and when installing the Hosting Bundle. When installing the Hosting Bundle it winds up right next to the key for the dotnet/runtime SharedFx.

@wtgodbe
Copy link
Member Author

wtgodbe commented May 2, 2024

/backport to release/8.0

@wtgodbe
Copy link
Member Author

wtgodbe commented May 2, 2024

/backport to release/6.0

Copy link
Contributor

github-actions bot commented May 2, 2024

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/8931091469

Copy link
Contributor

github-actions bot commented May 2, 2024

Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/8931092119

@wtgodbe wtgodbe merged commit 6ef0fe5 into main May 2, 2024
26 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/BundleRegKey branch May 2, 2024 22:46
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview5 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing registry keys for Microsoft.AspNetCore.App
2 participants