New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Partitioned cookie attribute #55371
base: main
Are you sure you want to change the base?
Conversation
...to support CHIPS (Cookies Having Independent Partitioned State). Fixes dotnet#53224 Fixes dotnet#55370
@blowdart I just left a comment on the issue you filed for this, but I'll repeat it here. Are we really doing this for an expired draft spec that's only supported by chromium-based browsers when the workaround is nearly as easy to use as the proposed API? New API: options.Cookie.Partitioned = true; Workaround: options.Cookie.Extensions.Add("partitioned"); We did approve the API, but we were a little rushed. And I don't think the workaround was ever demonstrated. The simplicity of the workaround really makes me want to hold off on this until the spec is final. |
I take your point about the spec, but it's one of those that is unlikely to change (in my opinion) now that cookie has full throttle committed to it. |
I'm guessing that was meant to be "chrome has full throttle committed to it". |
Mozilla views it positively (Basically we'll add it soon) Google started the staged rollout in chrome for 1% of users. although they stopped because regulators objected. |
} | ||
|
||
[Flags] | ||
private enum MessagesToLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it matters here, as the enum isn't embedded in a type.
private enum MessagesToLog | |
private enum MessagesToLog : byte |
to make the enum smaller (1 byte vs. 4 bytes for int
(default)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I considered that, but decided against it for two reasons. First, I'm expecting there to be more flags in the future. I've already added one since the PR began. 😆 Second, I figured space saving was probably less valuable than simplified alignment on the stack (though I didn't measure).
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
...to support CHIPS (Cookies Having Independent Partitioned State).
Fixes #53224
Fixes #55370