Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] OpenGL Codegen #2020

Merged
merged 21 commits into from
May 26, 2024
Merged

[3.0] OpenGL Codegen #2020

merged 21 commits into from
May 26, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented Apr 6, 2024 •
edited

  • Group generation
  • Function transformation to refer to groups
  • Transformative overloads (e.g. GenBuffer vs GenBuffers)
  • SupportedApiProfileAttributes
  • more...?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 6, 2024 •
edited

File Coverage
All files 8% ✅

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 5eca8c3

Perksey and others added 15 commits April 6, 2024 22:25
@Perksey
Base typing and namespacing
678dc6e
@Perksey
Cast enum members, fix stray semicolons, Silk.NET.OpenGL builds again
52e401a
@Perksey
Group and bool transformations
5219292
@Perksey
Fix erroneous cast order
710fa56
@Perksey
Add Delete(singular) overloads (ArrayParameterOverloader)
ea85042
@Perksey
Add SAL object model & Khronos length metadata parsing
4376388
@Perksey
ArrayParameterTransformer w/ tests
3214433
@Perksey
Integrate ArrayParameterTransformer
220afd0
@Perksey
Merge branch 'develop/3.0' into feature/opengl-codegen
7eec321
@Perksey
Support SupportedApiProfileAttribute generation with metadata
4450085
@Perksey
PrettifyNames conflict resolution now actually works
d523e37
@Perksey
Fix casting transformation ambiguity bugs
90da556
@Perksey
Fix metadata retrieval for reserved identifiers
4f85362
@Perksey
Merge branch 'feature/opengl-codegen' of https://github.com/dotnet/Si…
110a782 
…lk.NET into feature/opengl-codegen
@Perksey
Fix unit tests
24343a8
Perksey
Perksey commented May 23, 2024
View reviewed changes
Copy link
Member Author

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

sources/Core/Annotations/SupportedApiProfileAttribute.cs Outdated Show resolved Hide resolved
sources/Core/DSL/MaybeBool`2.cs Outdated Show resolved Hide resolved
sources/OpenGL/Enums/AttribMask.gen.cs Show resolved Hide resolved
sources/OpenGL/Enums/BlendingFactor.gen.cs Outdated Show resolved Hide resolved
sources/OpenGL/Enums/ContextFlagMask.gen.cs Show resolved Hide resolved
sources/OpenGL/Enums/DepthFunction.gen.cs Show resolved Hide resolved
sources/OpenGL/Enums/FragmentShaderColorModMaskATI.gen.cs Outdated Show resolved Hide resolved
sources/SilkTouch/Mods/Common/ModUtils.cs Outdated Show resolved Hide resolved
sources/SilkTouch/Mods/Metadata/MetadataUtils.cs Show resolved Hide resolved
sources/SilkTouch/Mods/MixKhronosData.cs Outdated Show resolved Hide resolved
@Perksey Perksey mentioned this pull request May 23, 2024
Open
32 tasks
@Perksey Perksey marked this pull request as ready for review May 24, 2024 04:34
@Perksey Perksey requested a review from a team as a code owner May 24, 2024 04:34
@Perksey
Copy link
Member Author

Perksey commented May 24, 2024

This is now ready for review. Note that it doesn't include handle codegen, but everything else is basically as it will be in the final release afaict.

@Perksey Perksey requested a review from curin May 24, 2024 04:35
@Perksey Perksey added the feature New feature. label May 24, 2024
@Perksey Perksey enabled auto-merge (squash) May 26, 2024 16:25
@Perksey Perksey disabled auto-merge May 26, 2024 16:25
@Perksey Perksey merged commit ca92db9 into develop/3.0 May 26, 2024
15 checks passed
@Perksey Perksey deleted the feature/opengl-codegen branch May 26, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curin curin curin approved these changes

Assignees

@curin curin

Labels
area-SilkTouch feature New feature.
Projects
Silk.NET Development Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Perksey @curin