Switches for HasSupportFragmentInjector and HasFragmentInjector #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
--- JIRA LINKS --- |
rainqer
suggested changes
Oct 2, 2017
| @@ -22,4 +27,8 @@ class SampleApp : Application(), HasActivityInjector { | |||
|
|
|||
| override fun activityInjector(): AndroidInjector<Activity> = dispatchingAndroidInjector | |||
|
|
|||
| override fun fragmentInjector(): AndroidInjector<android.app.Fragment> = dispatchingFragmentInjector | |||
There was a problem hiding this comment.
You need it to have Fragments injected in the app. Android's fragments or support ones. Or both, since technically you can have both, for whatever reason.
Without these dispatching injectors Dagger goes \(ツ)/¯
Forgot about import alias, so I may opt out for a SupportFragment alias instead of full package path.
bhm
force-pushed
the
switches-for-dispatching-injectors
branch
from
9579356
to
9b7cd60
Compare
bhm
force-pushed
the
switches-for-dispatching-injectors
branch
from
9b7cd60
to
f77e0d1
Compare
|
This got updated |
|
@rainqer do we care to merge it? |
PawelSwietochowski
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.