Add force_pkce option #1705
Merged
Add force_pkce option #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The force_pkce option is disabled by default. When enabled, it requires non-confidential clients to use PKCE when requesting an access_token using an authorization code.
|
@nbulaj Any feedback on this? We've now implemented it as monkeypatches in my company's app, but it would be cool to get it into the gem. I'm happy to make changes to the design or the implementation if you have any issues with the current code. Thanks! |
|
hey @mattmanning , I find it great, thanks! Let me check the implementation details |
nbulaj
reviewed
May 21, 2024
doorkeeper.gemspec
Outdated
| @@ -52,6 +52,7 @@ Gem::Specification.new do |gem| | |||
| gem.add_development_dependency "factory_bot", "~> 6.0" | |||
| gem.add_development_dependency "generator_spec", "~> 0.10.0" | |||
| gem.add_development_dependency "grape" | |||
| gem.add_development_dependency "pry-byebug" | |||
There was a problem hiding this comment.
I don't find pry / byebug useful, can we avoid adding it there please?
|
@nbulaj Thank you for looking! I have removed pry-byebug. Please let me know if you would like any other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force_pkce option is disabled by default. When enabled, it requires non-confidential clients to use PKCE when requesting an access_token using an authorization code.
Summary
PKCE should be used for all non-confidential clients (those who can't protect their client_secret). However, since the OAuth 2.0 spec doesn't require it, it should be disabled by default and only used if desired by the server. https://www.rfc-editor.org/rfc/rfc7636#section-5
Other Information
This implementation is slightly different than what was discussed in #1654. A more stringent option that also requires PKCE for confidential clients could later be added to a bundled OAuth 2.1 option.