New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dompdf_tempnam #842
Open
vavrecan
wants to merge
4
commits into
dompdf:master
Choose a base branch
from
vavrecan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dompdf_tempnam #842
+92
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and do not have to be necessary cached. Created new setting - local protocols - that allows to specify list of them. This is usefull when protocol is for example: gs protocol (gs://) on google app engine php protocol for reading data from memory or temp php://memory php://file data protocol that is supported in php 5.1 and newer
vavrecan
changed the title
Added support for custom protocols wrapper that supports stat functions ...
dompdf_tempnam
Jul 3, 2014
Looks interesting. We'd like to avoid merging changes directly into the master branch where possible. Target your changes to the develop branch and we'll take a closer look. |
If you have time to fix up this PR I'd be grateful. Still seems like a potentially good fix and I'll look at it more for the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created custom handler for tempnam, for hosting with safemode on, for example google app engine. Uses custom memory php wrapper.