Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow searching files in chroot options directories #3444

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

allow searching files in chroot options directories #3444

wants to merge 4 commits into from

Conversation

eltharin
Copy link

with chroot option set to ['/dir/dir1', /dir/dir2'] files will be search there too,

ex : wiil be search in basePath AND in /dir/dir1/css/file.css or /dir/dir2/css/file.css

bsweeney
bsweeney reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@bsweeney bsweeney left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable modification for a common request (setting the file root to a document directory).

In addition to this we'll need to change all methods that call build_url will need to be updated to include $chroot.

src/Helpers.php Outdated Show resolved Hide resolved
@bsweeney bsweeney added this to the 3.1.0 milestone Apr 22, 2024
eltharin and others added 2 commits April 22, 2024 16:10
@eltharin @bsweeney
Update src/Helpers.php
c12b41d 
Co-authored-by: Brian Sweeney <brian@eclecticgeek.com>
@eltharin
call with chroot direcotries
9f8eafb
@eltharin
Copy link
Author

yes it can be better to call build_url with with argument now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsweeney bsweeney bsweeney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eltharin @bsweeney