Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ident type, getNum -> getInt #13

Open
wants to merge 1 commit into
base: v1.2.6
Choose a base branch
from

Conversation

dlesnoff
Copy link

@dlesnoff dlesnoff commented Sep 14, 2022

I have, in chapter 9 about the config macro:

  • fixed import (json functions were used inside the macro)
  • Remove deprecated NimIdent type: NimIdent->string, object.ident -> object.strVal
  • getNum is now getInt
  • move away example under a when isMainModule section. It allows to test the file without having to comment them each time we use the macro in another file. Avoids to import the test along the macro.

Oh sorry for the branch choice, these changes have been added by ulterior versions than 1.2.6, I have run code with 1.6.6 (current latest stable).

@dom96
Copy link
Owner

dom96 commented Sep 16, 2022

When did these changes become required for successful compilation? Do we need a new branch for that version?

@dlesnoff
Copy link
Author

Actually no, I have done testing with 1.2.6, I get the same warnings (deprecated since 0.18.1 !)
and the same getNum error.
Obviously, I got same error and warnings with ulterior 1.4.8 version.

@dom96
Copy link
Owner

dom96 commented Sep 19, 2022

Do you get these as warnings or do they fail compilation? The branches only need to compile successfully.

@dlesnoff
Copy link
Author

dlesnoff commented Sep 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants