Externals: Update OpenAL-Soft to 1.23.1

[Xphalnos]

I updated OpenAL-Soft because it hasn't been updated for 10 years!

[AdmiralCurtiss]

I'm a bit confused about these headers. Where do the matching binaries come from?

[Xphalnos]

They come from OpenAL Soft
Link: https://github.com/kcat/openal-soft

[AdmiralCurtiss]

What I meant was, how does Dolphin actually link against the binary? But after checking, it doesn't at all and expects the user to provide the dll for it:

dolphin/Source/Core/AudioCommon/OpenALStream.cpp

Line 73 in c8ea116

s_openal_dll = ::LoadLibrary(TEXT("openal32.dll"));

It also is only implemented for Windows, which is also pretty weird. I wonder when the last time anyone even used this audio backend was...

e: Some old downloads on dolphin-emu.org do include the DLL though. But newer versions don't anymore. Did anyone even notice this?

[AdmiralCurtiss]

Also, are you sure you got the right headers? Whatever you got here does not match the headers in the 1.23.1 release.

[Xphalnos]

However I simply copied the files from https://github.com/kcat/openal-soft

[Xphalnos]

Otherwise I can take the RPCS3 files https://github.com/RPCS3/rpcs3/tree/master/3rdparty/OpenAL

[CasualPokePlayer]

Official "base" headers would Creative Labs's OpenAL SDK, which is available on OpenAL's official site. Dolphin does not necessarily use OpenAL Soft, but rather any OpenAL 1.1 compliant implementation (of which there are several, although practically there's just the Creative Lab's implementation, OpenAL Soft, and I guess Apple OpenAL exists?). In this case, judging from the copyright headers the headers Dolphin uses appear to be from a really old version of OpenAL Soft? (alext.h is definitely not from the base SDK anyways; although this OpenAL Soft version seems so old the base headers appear to be copies of the official base SDK).

OpenAL also hasn't received any updates to their base API past 1.1 (spec released in 2005, although the core SDK apparently last changed in 2009?). The actual implementation version isn't of much concern for Dolphin, that's up to the user or package manager providing the shared library (although I guess this is kind of undercut by this being a Windows specific backend? It should be possibly to trivially make available on any platform, which is probably useful for obscure Unix like platforms if anything?).