RetroAchievements - Discord Presence

[LillyJadeKatrin]

Sends RetroAchievements Rich Presence to Discord as its presence text provided the correct settings are enabled.

Rebase of #12594 after the refactor to rc_client.

[iwubcode]

Code LGTM. Untested.

[AdmiralCurtiss]

Are you sure this is right? I think for strings > 128 this would insert the ... in the middle of the string instead of replacing the end.

[iwubcode]

Gah, I was thinking of it wrong too.

Probably should be something like: state_string = fmt::format("{}...", state_string.substr(0, 124));

[LillyJadeKatrin]

My understanding was that this would insert ...\0 into the middle of the string and thus cut it off when it copies to a cstring?

[AdmiralCurtiss]

Ah, yeah you're right, but that's really not obvious with how the code is written. But yeah fair enough.

[neobrain]

A more easily verifiable approach is this:

Suggested change

	state_string.replace(124, 4, "...");
	state_string.resize(124);
	state_string += "...";

(not that it mattered here, but this won't have overhead since down-sizing string never re-allocates)

As a side note, std::string's null terminator is not included in its length(), but the comment suggests a different assumption was made. Might be worth double-checking.

[AdmiralCurtiss]

Please hide the Discord presence option in the Achievement UI if RetroAchievements is enabled but Discord is disabled. (USE_DISCORD_PRESENCE off, USE_RETRO_ACHIEVEMENTS on)

[LillyJadeKatrin]

Completely hide, or could I just gray it out like with other settings here when they're not active?

[mbc07]

Since we have a discoverability issue here (two related settings at completely different places in the GUI), I'd be in favor of leaving the option in the achievements UI always visible but grayed out when Discord integration is disabled (bonus points if the tooltip also explains why it can't be enabled)...

[AdmiralCurtiss]

Ah, I was talking about the compile time switch that disables Discord integration from being compiled altogether, but yes that is a good point too.

So:

• If Discord is disabled at compile time, don't show the checkbox at all.
• If Discord is enabled at compile time but currently disabled in the settings, show the box but grey it out.
• If Discord is enabled at compile time and currently enabled in the settings, show the box regularly.

The tooltip for the box should indeed contain that the regular Discord integration needs to be enabled.

[LillyJadeKatrin]

OH right good call, got it.

[AdmiralCurtiss]

I'm not entirely sure whether the reset_timer flag makes sense but we'll probably figure this out in actual usage.

[LillyJadeKatrin]

FYI the reset_timer flag was because we noticed while testing that without specifying this, the "time played" timer was resetting every time the RP was updating instead of actually reporting the amount of time spent in game. But let me know if we want to change the specific implementation of it.