Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScmRevGen: Generate Info.plist files containing the current version #12728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ScmRevGen: Generate Info.plist files containing the current version #12728

wants to merge 3 commits into from
+33 −10

Conversation

OatmealDome
Copy link
Member

On macOS, our app bundle currently has no version number set. This was broken in a previous ScmRevGen-related commit, as the necessary version variables no longer exist outside of the ScmRevGen cmake instance.

So, let's have ScmRevGen generate the Info.plist for us.

BhaaLseN
BhaaLseN reviewed Apr 21, 2024
View reviewed changes
CMake/ScmRevGen.cmake Outdated Show resolved Hide resolved
@AdmiralCurtiss
Copy link
Contributor

The CMake code itself looks sane, but I have never touched macOS in my life so I cannot tell you whether this is actually correct for the platform.

@OatmealDome
Copy link
Member Author

OatmealDome commented May 24, 2024 •
edited

If the CMake makes sense, that's good enough for me. (I tested the build artifacts and they seem to work fine.) I'll wait like a day or so and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@OatmealDome @AdmiralCurtiss @BhaaLseN