Remove defined-out code #12712
Open
Remove defined-out code #12712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BhaaLseN
reviewed
Apr 16, 2024
Comment on lines
-122
to
-127
| #if 0 | ||
| INFO_LOG_FMT(DSPHLE, "Command list:"); | ||
| for (u32 i = 0; m_cmdlist[i] != CMD_END; ++i) | ||
| INFO_LOG_FMT(DSPHLE, "{:04x}", m_cmdlist[i]); | ||
| INFO_LOG_FMT(DSPHLE, "-------------"); | ||
| #endif |
There was a problem hiding this comment.
This one used to have a purpose: log the AX command list in case someone needed it; but only when compiled in. No strong feelings if we want to remove it though, it's easy enough to rewrite from scratch if necessary 👍
dreamsyntax
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove various blocks of code that are surrounded by
#if 0or commented out. Some of these have been hanging around for more than a decade.I chose to keep the loops instead of the unrolling since we don't normally do that, but I can do it the other way around if someone thinks it's worth it.