Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputCommon: Fix unnecessary "Modifier/Range" ini file entries. #12711

Merged

Conversation

jordan-woyak
Copy link
Member

This prevents "Modifier/Range" values from saving if they are the default of 50%.
It was annoying that even non-configured Wii Remotes produced many of these ini file lines.

It changes this:

[Wiimote3]
Device = XInput2/0/Virtual core pointer
Source = 0
Tilt/Modifier/Range = 50.
Nunchuk/Stick/Modifier/Range = 50.
Nunchuk/Tilt/Modifier/Range = 50.
Classic/Left Stick/Modifier/Range = 50.
Classic/Right Stick/Modifier/Range = 50.
Guitar/Stick/Modifier/Range = 50.
Drums/Stick/Modifier/Range = 50.
Turntable/Stick/Modifier/Range = 50.
uDraw/Stylus/Modifier/Range = 50.
Drawsome/Stylus/Modifier/Range = 50.
[Wiimote4]
Device = XInput2/0/Virtual core pointer
Source = 0
Tilt/Modifier/Range = 50.
Nunchuk/Stick/Modifier/Range = 50.
Nunchuk/Tilt/Modifier/Range = 50.
Classic/Left Stick/Modifier/Range = 50.
Classic/Right Stick/Modifier/Range = 50.
Guitar/Stick/Modifier/Range = 50.
Drums/Stick/Modifier/Range = 50.
Turntable/Stick/Modifier/Range = 50.
uDraw/Stylus/Modifier/Range = 50.
Drawsome/Stylus/Modifier/Range = 50.
[BalanceBoard]
Device = XInput2/0/Virtual core pointer
Source = 0
Tilt/Modifier/Range = 50.
Nunchuk/Stick/Modifier/Range = 50.
Nunchuk/Tilt/Modifier/Range = 50.
Classic/Left Stick/Modifier/Range = 50.
Classic/Right Stick/Modifier/Range = 50.
Guitar/Stick/Modifier/Range = 50.
Drums/Stick/Modifier/Range = 50.
Turntable/Stick/Modifier/Range = 50.
uDraw/Stylus/Modifier/Range = 50.
Drawsome/Stylus/Modifier/Range = 50.

To this:

[Wiimote3]
Device = XInput2/0/Virtual core pointer
Source = 0
[Wiimote4]
Device = XInput2/0/Virtual core pointer
Source = 0
[BalanceBoard]
Device = XInput2/0/Virtual core pointer
Source = 0

@AdmiralCurtiss AdmiralCurtiss merged commit 321dc9b into dolphin-emu:master May 21, 2024
11 checks passed
@jordan-woyak jordan-woyak deleted the modifier-range-ini-default branch May 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants