New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional conversion & eol for OSREPORT #12581
base: master
Are you sure you want to change the base?
Conversation
I might be completely wrong and EXI-IPL isn't my forte but isn't this a "hack" since the logging system automatically append a newline? Otherwise, could it be something done by the GC/Wii SDK? AFAICT, most of the games I have with debug message strings are |
For an example of how to add a setting, see 23ad07b. (Skip the change in IsSettingSaveable.cpp – it isn't needed nowadays. Adding the setting to the Android code is optional.) |
Yes, e.g. Super Mario Galaxy and Super Mario Sunshine both have debug messages that end up here (but the way you boot the game matters; if you use the Wii menu or gamecube menu then they won't log anything because they won't think they're in debug mode). Super Mario Galaxy in particular logs several DSP-related messages in Japanese on startup.
The UTF-8 does seem like a good option to have. |
This is interesting and kind of suggests old school serial tty where commands were sent when user pressed return & sent \r then the other end responded with \n to signal ready for another transmission. (I only know this because I used to service minicomputers and their vt52/100/220 terminals. :) ) I think it's probably reasonable in that case for libogc uart code to just translate
|
c94ea6f
to
174447b
Compare
What's the state here? |
Recently I added code in libogc to allow homebrew to send OSREPORT messages to Dolphin but it seems more sensible to use \n to end the message and stick with UTF8 encoding on the application side. I presume that commercial games have left debug messages which follow this format? I've used variables here to default to \n and no conversion from Shift JIS but my intention is to add checkboxes in the UI to set this as appropriate & store it as a setting.
I was thinking about adding either checkboxes or dropdowns to the the log window here https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/DolphinQt/Config/LogWidget.cpp#L140 but I'm not entirely sure of the best way to get settings configured there back to the code in EXI_DeviceIPL. Could someone point me in the right direction?