[d3d9] Options parser vendorID fix and DF format support validation rework #4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
approved these changes
May 22, 2024
K0bin
reviewed
May 22, 2024
WinterSnowfall
force-pushed
the
d3d9-options-fix
branch
from
c138a43
to
e93fdad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing the use of customDeviceId for vendorID was unintentional, right? 馃槄 Not that it affected much beyond VQuery support on the few titles that have Nvidia vendorID (& deviceID) overrides set in place (even then, only on AMD and Intel).
Also moved the DF Format support disabling on Nvidia during options parsing, sorry for not doing that earlier (didn't really think a vendorID check was already done there, so didn't bother to check).