Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added onSnapToItem trigger for didMount and update index changing logic #524

Open
wants to merge 1 commit into
base: v3.x.x
Choose a base branch
from

Conversation

karkengc
Copy link

@karkengc karkengc commented Jan 8, 2024

Changes made is to fix below issue:

  1. No onSnapToItem trigger for initially mounted carousel item
  2. For when loop is true, the index changes when scrolling beyond 1 loop and back to index=0, the index is first changed to rawDataLength before resetting to 0, which will cause slight delay when updating pagination dots.

Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: 35a5930

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2024
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ❌ Failed (Inspect) Jan 8, 2024 2:43am

@oliverloops
Copy link
Collaborator

Hi @karkengc, let me test it out and see if I can merge it. thank you :)

@karkengc
Copy link
Author

karkengc commented Feb 16, 2024

Hi @karkengc, let me test it out and see if I can merge it. thank you :)

Hi @oliverloops, just wondering have you gone through it yet 😀

@manuwebs
Copy link

Hi @karkengc , don't know if you will find this useful but basically this is what I did this in order to fix the delay

using the exported fn onProgressChange I use the following handler

const handleProgressChange = (_: number, progress: number) => setCurrentIndex(Math.round(progress) % data.length);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants