Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: off-by-one error in visible ranges calculation #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

js0n
Copy link

@js0n js0n commented Aug 9, 2023

Currently, there's an issue with the useVisibleRanges calculation.

For example, when a windowSize of 3 is specified, the visible range specified by { negativeRange, positiveRange } when scrolled to the end of the carousel sets the shouldUpdate state variable for 4 items instead of 3.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 5cc1cd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@js0n js0n changed the base branch from v3.x.x to main August 9, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant