Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added teams url under a team name in teams section #951

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sumitbishti
Copy link
Contributor

@sumitbishti sumitbishti commented Feb 20, 2024

fixes: #943
Screenshot 2024-02-19 211732

Video Link: https://www.loom.com/share/35328504cf3f46e9be78bd485252e8dc?sid=1f309776-8b52-4af4-b86b-652b762fef5b

Summary by CodeRabbit

  • Chores
    • Updated export settings for UI components without altering functionality.

Copy link

vercel bot commented Feb 20, 2024

@sumitbishti is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the apps: web Issues related to the webapp label Feb 20, 2024
Copy link

github-actions bot commented Feb 20, 2024

Hey There! and thank you for opening this pull request! 📝👋🏼

We require pull request titles to follow the Conventional Commits Spec and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "added teams url under a team name in teams section". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Contributor

coderabbitai bot commented Feb 20, 2024

Walkthrough

The change involves a simple alteration in the codebase where the same set of entities are re-exported in avatar.tsx without any functional changes. This update does not introduce new features or modifications to existing functionality.

Changes

File Path Change Summary
packages/.../avatar.tsx Re-export of entities without functional modifications.

Assessment against linked issues

Objective Addressed Explanation
Add a differentiator to the teams in Profile Dropdown (#943) The change in avatar.tsx does not relate to adding team differentiators.

In conclusion, the current changes do not address the primary objectives outlined in the linked issue #943, which seeks to add differentiators for teams in the profile dropdown. The modification in avatar.tsx is unrelated to this requirement.


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 80c758f and 30f47ef.
Files selected for processing (1)
  • packages/ui/primitives/avatar.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ui/primitives/avatar.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dguyen
Copy link
Collaborator

dguyen commented Feb 22, 2024

You should be able to do all this with just css, no need for state or changes to AvatarWithText component

{teams.map((team) => (
  <DropdownMenuItem asChild key={team.id}>
    <Link href={formatRedirectUrlOnSwitch(team.url)} className="group">
      <AvatarWithText
        avatarFallback={formatAvatarFallback(team.name)}
        primaryText={team.name}
        secondaryText={
          <>
            <span className="opacity group-hover:hidden">
              {formatSecondaryAvatarText(team)}
            </span>
            <span className="opacity-0 group-hover:opacity-100">{`/t/${team.url}`}</span>
          </>
        }
        rightSideComponent={
          isPathTeamUrl(team.url) && (
            <CheckCircle2 className="ml-auto fill-black text-white dark:fill-white dark:text-black" />
          )
        }
      />
    </Link>
  </DropdownMenuItem>
))}

Also would probably be nice to disable this feature if there's only 1 team.

@sumitbishti
Copy link
Contributor Author

Also would probably be nice to disable this feature if there's only 1 team.

i think we should keep it. It would be more consistent that way.

@dguyen
Copy link
Collaborator

dguyen commented Feb 23, 2024

The goal of this feature is to distinguish between duplicate names for teams, which is unlikely in the first place.

We expect the majority of people with teams to generally will have 1 team, and if they had more it would be unlikely to have duplicate names.

So it doesn't really make sense to have this for one team.

@dguyen
Copy link
Collaborator

dguyen commented Apr 4, 2024

Hey @sumitbishti there doesn't appear to be any changes in this PR, which is fine

If you don't feel like proceeding we can close this?

@sumitbishti
Copy link
Contributor Author

sumitbishti commented Apr 15, 2024

No actually there are changes. I'll push them shortly. I thought i had pushed them! My bad.

@sumitbishti
Copy link
Contributor Author

Hey @dguyen i have opened a new PR (#1122) for this. After processing that one you can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add a differentiator to the teams in Profile Dropdown
2 participants