Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: i18n and localization documenso #919

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Feb 7, 2024

  • internationalized routing and locale detection
  • offer dropdown to change language

currently supporting-

  • English
  • French
  • Spanish
  • German
  • Italian
  • Portuguese

Copy link

vercel bot commented Feb 7, 2024

@anikdhabal is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added apps: web Issues related to the webapp version bump 👀 apps: marketing Issues related to website or marketing app labels Feb 7, 2024
Copy link
Contributor

coderabbitai bot commented Feb 7, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@kodermax
Copy link

kodermax commented Feb 7, 2024

@anikdhabal Cool job, I would like to suggest a cookie-based language detection option.
Here are some advantages of changing the website language based on cookies rather than URLs like /en/:

Cleaner URLs - Removing the language tag from URLs results in simpler, cleaner, more user-friendly URLs that are easier to read and remember for visitors.

Better SEO - Eliminating duplicate URLs for different languages helps avoid splitting page equity between them, consolidating ranking signals for better SEO.

Easier navigation - Users can navigate the site in their language without having to constantly click language-tagged URLs. The experience feels more natural.

Greater flexibility - Cookies allow implementing more flexible logic, like auto-detecting user language, remembering language preferences across sessions, allowing switching languages quickly.

Avoiding thin content issues - Prevent duplicate low-value /en/ URLs that might be seen as "thin content" by search engines, leading to dilution of page rankings.

Internationalization - Cookies make it easier to expand the site to more languages without exponential URL growth. Language can be added just by adding a cookie value.

In summary, cookies provide a cleaner solution for handling multi-language websites, creating simpler URLs, improved SEO capabilities, better user experience, and greater flexibility for internationalization.

@anikdhabal
Copy link
Contributor Author

anikdhabal commented Feb 7, 2024

@anikdhabal Cool job, I would like to suggest a cookie-based language detection option. Here are some advantages of changing the website language based on cookies rather than URLs like /en/:

Cleaner URLs - Removing the language tag from URLs results in simpler, cleaner, more user-friendly URLs that are easier to read and remember for visitors.

Better SEO - Eliminating duplicate URLs for different languages helps avoid splitting page equity between them, consolidating ranking signals for better SEO.

Easier navigation - Users can navigate the site in their language without having to constantly click language-tagged URLs. The experience feels more natural.

Greater flexibility - Cookies allow implementing more flexible logic, like auto-detecting user language, remembering language preferences across sessions, allowing switching languages quickly.

Avoiding thin content issues - Prevent duplicate low-value /en/ URLs that might be seen as "thin content" by search engines, leading to dilution of page rankings.

Internationalization - Cookies make it easier to expand the site to more languages without exponential URL growth. Language can be added just by adding a cookie value.

In summary, cookies provide a cleaner solution for handling multi-language websites, creating simpler URLs, improved SEO capabilities, better user experience, and greater flexibility for internationalization.

@kodermax thanks for the suggestion. I was thinking about this before. Let see.

@dguyen
Copy link
Collaborator

dguyen commented Feb 7, 2024

@anikdhabal I'm not really familiar with the i18n libraries, did you generate the common.json translation files manually yourself?

@anikdhabal
Copy link
Contributor Author

anikdhabal commented Feb 8, 2024

@anikdhabal I'm not really familiar with the i18n libraries, did you generate the common.json translation files manually yourself?

Yes, I generate those manually to ensure they are all correct.

@anikdhabal anikdhabal marked this pull request as draft February 10, 2024 10:48
@itechwebsolutions
Copy link

hi when changing the language in the /documents page.
the program is crashing, how can we fix this bug?

@anikdhabal
Copy link
Contributor Author

hi when changing the language in the /documents page. the program is crashing, how can we fix this bug?

Hey, first of all, it's working fine for me. And these are not the final changes. I want to handle marketing and the main app differently. Currently, I am working on it and will finalize things soon.

@celevra celevra mentioned this pull request May 8, 2024
6 tasks
@celevra
Copy link

celevra commented May 8, 2024

if you need german translation i can help

@laurocesar
Copy link

Hi @anikdhabal

How are you going here? I can help you with portuguese translation if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: marketing Issues related to website or marketing app apps: web Issues related to the webapp version bump 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants