New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: i18n and localization documenso #919
base: main
Are you sure you want to change the base?
Conversation
@anikdhabal is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@anikdhabal Cool job, I would like to suggest a cookie-based language detection option. Cleaner URLs - Removing the language tag from URLs results in simpler, cleaner, more user-friendly URLs that are easier to read and remember for visitors. Better SEO - Eliminating duplicate URLs for different languages helps avoid splitting page equity between them, consolidating ranking signals for better SEO. Easier navigation - Users can navigate the site in their language without having to constantly click language-tagged URLs. The experience feels more natural. Greater flexibility - Cookies allow implementing more flexible logic, like auto-detecting user language, remembering language preferences across sessions, allowing switching languages quickly. Avoiding thin content issues - Prevent duplicate low-value /en/ URLs that might be seen as "thin content" by search engines, leading to dilution of page rankings. Internationalization - Cookies make it easier to expand the site to more languages without exponential URL growth. Language can be added just by adding a cookie value. In summary, cookies provide a cleaner solution for handling multi-language websites, creating simpler URLs, improved SEO capabilities, better user experience, and greater flexibility for internationalization. |
@kodermax thanks for the suggestion. I was thinking about this before. Let see. |
@anikdhabal I'm not really familiar with the i18n libraries, did you generate the common.json translation files manually yourself? |
Yes, I generate those manually to ensure they are all correct. |
hi when changing the language in the /documents page. |
Hey, first of all, it's working fine for me. And these are not the final changes. I want to handle marketing and the main app differently. Currently, I am working on it and will finalize things soon. |
if you need german translation i can help |
Hi @anikdhabal How are you going here? I can help you with portuguese translation if you need it. |
currently supporting-