feat: add support for uploading signature #905

harkiratsm · 2024-02-05T14:25:34Z

This PR #765

Implemented support for signature uploads, enabling users to upload their signatures and sign documents. Updated the User table to store the signature type, facilitating document signing based on the uploaded signature.

enum SignatureType {
  DRAW
  UPLOAD
}

Screenshots -

Demo -

doci.mov

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

vercel · 2024-02-05T14:25:38Z

@harkiratsm is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-02-05T14:25:49Z

Thank you for following the naming conventions for pull request titles! 💚🚀

coderabbitai · 2024-02-05T14:31:04Z

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Mythie · 2024-02-07T02:03:55Z

Before I go down the rabbit hole of reviewing this completely I've noticed that we've made a database change for this. My assumption would have been that we would have the user upload an image and then apply it to the signature canvas (fit to canvas) and grayscale it as needed.

This would mean it's no different from a drawn signature from a storage perspective and should be easier to manage.

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

harkiratsm · 2024-02-11T04:24:41Z

/ready-for-review @Mythie @adithyaakrishna @catalinpit

adithyaakrishna · 2024-02-12T09:49:34Z

Thanks @harkiratsm 🚀
I'll clone it locally and review it soon :)

…rkirat/image

sachin-duhan · 2024-04-09T20:20:13Z

apps/web/src/app/(signing)/sign/[token]/signature-field.tsx

+  const [localSignature, setLocalSignature] = useState<{
+    value: string | null;
+    type: SignatureType | null;
+  } | null>();


isolating useState Type to respective type.ts file is recommended/

sachin-duhan · 2024-04-09T20:21:47Z

apps/web/src/app/(signing)/sign/[token]/signature-field.tsx

@@ -90,7 +100,8 @@ export const SignatureField = ({ field, recipient }: SignatureFieldProps) => {
      });

      if (source === 'local' && !providedSignature) {
-        setProvidedSignature(localSignature);
+        setProvidedSignature(localSignature?.value ?? '');
+        setProvidedSignatureType(localSignature?.type ?? 'DRAW');


use SignatureType.DRAW instead of 'DRAW'?

sachin-duhan · 2024-04-09T20:22:37Z

apps/web/src/app/(signing)/sign/[token]/signature-field.tsx

+              onChange={(value: string | null, isUploaded: boolean) => {
+                setLocalSignature({
+                  value,
+                  type: isUploaded ? SignatureType.UPLOAD : SignatureType.DRAW,
+                });
+              }}


for complex onChange function, it's better them to define them as function and use them in JSX

sachin-duhan · 2024-04-09T20:24:13Z

apps/web/src/components/forms/profile.tsx

+                    onChange={(v: string | null, isUploaded: boolean) =>
+                      handleSignatureChange(v, isUploaded)
+                    }


You can simply write

onChange={handleSignatureChange}

sachin-duhan · 2024-04-09T20:24:50Z

apps/web/src/components/forms/signup.tsx

@@ -65,6 +69,7 @@ export const SignUpForm = ({ className, initialEmail, isGoogleSSOEnabled }: Sign
      email: initialEmail ?? '',
      password: '',
      signature: '',
+      signatureType: 'DRAW',


replace ''DRAW' with SignatureType.DRAW

sachin-duhan · 2024-04-09T20:25:41Z

apps/web/src/components/forms/signup.tsx

+                    onChange={(v: string | null, isUploaded: boolean) =>
+                      handleSignatureChange(v, isUploaded)
+                    }


You can simply write

onChange={handleSignatureChange}

feat: add support for uploading signature

e341b1e

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

harkiratsm marked this pull request as draft February 5, 2024 14:25

github-actions bot added apps: web Issues related to the webapp 🚨 migrations 🚨 labels Feb 5, 2024

harkiratsm added 2 commits February 9, 2024 22:44

add removing of the uploaded sign

7abd156

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

fix the signature pad component

6241500

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

github-actions bot added the apps: marketing Issues related to website or marketing app label Feb 10, 2024

harkiratsm added 2 commits February 10, 2024 19:19

format code

1638534

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

resolve merge/conflicts

c62da64

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

harkiratsm marked this pull request as ready for review February 10, 2024 14:42

fix: tidy code

194371b

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

harkiratsm marked this pull request as draft February 10, 2024 17:45

harkiratsm marked this pull request as ready for review February 11, 2024 04:20

fix: uploading of signature

d8fd912

Signed-off-by: harkiratsm <multaniharry714@gmail.com>

Merge branch 'main' of https://github.com/documenso/documenso into ha…

9426558

…rkirat/image

harkiratsm mentioned this pull request Feb 14, 2024

Allow signatures to be created from an image #765

Open

5 tasks

ElTimuro linked an issue Feb 14, 2024 that may be closed by this pull request

Allow signatures to be created from an image #765

Open

5 tasks

Merge branch 'main' into harkirat/image

1ca4c25

sachin-duhan reviewed Apr 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for uploading signature #905

feat: add support for uploading signature #905

harkiratsm commented Feb 5, 2024 •

edited

vercel bot commented Feb 5, 2024

github-actions bot commented Feb 5, 2024 •

edited

coderabbitai bot commented Feb 5, 2024 •

edited

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

Mythie commented Feb 7, 2024

harkiratsm commented Feb 11, 2024

adithyaakrishna commented Feb 12, 2024

sachin-duhan Apr 9, 2024

sachin-duhan Apr 9, 2024

sachin-duhan Apr 9, 2024

sachin-duhan Apr 9, 2024

sachin-duhan Apr 9, 2024

sachin-duhan Apr 9, 2024

feat: add support for uploading signature #905

Are you sure you want to change the base?

feat: add support for uploading signature #905

Conversation

harkiratsm commented Feb 5, 2024 • edited

vercel bot commented Feb 5, 2024

github-actions bot commented Feb 5, 2024 • edited

coderabbitai bot commented Feb 5, 2024 • edited

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

Mythie commented Feb 7, 2024

harkiratsm commented Feb 11, 2024

adithyaakrishna commented Feb 12, 2024

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

sachin-duhan Apr 9, 2024

Choose a reason for hiding this comment

harkiratsm commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

coderabbitai bot commented Feb 5, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)