feat: force signature fields for document signers #1139
Conversation
|
Important Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| </DialogDescription> | ||
| </DialogHeader> | ||
| <DialogFooter> | ||
| <div className="flex w-full flex-nowrap gap-4"> |
There was a problem hiding this comment.
I think you should remove this div so we can use the normal layout for footers to stay consistent
There was a problem hiding this comment.
Ok, thanks. I did it, although the buttons on the webhook modal is also like this (buttons on the left side). I guess I should update that as well?
There was a problem hiding this comment.
Yeah just use the defaults which is right side
|
Can you add some server side checks as well? |
catalinpit
changed the title
| Cancel | ||
| </Button> | ||
| <Button type="submit" onClick={onOpenChange}> | ||
| Proceed |
There was a problem hiding this comment.
Do we still need both options if you can't proceed? Why the 2 buttons?
There was a problem hiding this comment.
True that. I kept it like this for consistency. Should I just go ahead and remove the proceed button?
There was a problem hiding this comment.
- Since this is not just a hint why you can't contine it can be a alert actually
Description
Show a dialog when the document has signers with no signature fields placed.
Changes Made
Created a new dialog that'll be triggered when the document owner tries to send a document to the signers without placing signature fields. The document owners can't proceed to the next step unless they add signature fields.
Checklist
signer.mp4