Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename "none" document access to "no restrictions" #1138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raikasdev
Copy link

@raikasdev raikasdev commented May 1, 2024

Description

Renames the "None" document access option to "Anyone with the link".
image
image

Related Issue

Fixes #1137

Changes Made

  • Renames the "None" document access option label

Testing Performed

Tested on my local envinronment. Well, it's only changing a label and a tooltip text 😄

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Copy link
Contributor

coderabbitai bot commented May 1, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented May 1, 2024

@raikasdev is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-docs ❌ Failed (Inspect) May 8, 2024 0:43am

@dguyen
Copy link
Collaborator

dguyen commented May 8, 2024

Hey! We like the wording with "Anyone with the link" but from a users perspective it might be confusing since to them it appears to just an email not a link

Whereas Google Docs is an actual link you copy

What do you think about "No Restrictions" instead?

@raikasdev
Copy link
Author

Hey! We like the wording with "Anyone with the link" but from a users perspective it might be confusing since to them it appears to just an email not a link

Whereas Google Docs is an actual link you copy

What do you think about "No Restrictions" instead?

That's great also! Gonna edit the PR later today

@raikasdev raikasdev changed the title chore: rename "none" document access to "anyone with the link" chore: rename "none" document access to "no restrictions" May 8, 2024
Copy link
Member

@ElTimuro ElTimuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks good
  • The action authentication could say "No authentication" but that's a matter of taste I guess

@raikasdev
Copy link
Author

  • Looks good
  • The action authentication could say "No authentication" but that's a matter of taste I guess

It's in the tooltip, so it should match the option imo.

@ElTimuro
Copy link
Member

ElTimuro commented May 8, 2024

  • Looks good
  • The action authentication could say "No authentication" but that's a matter of taste I guess

It's in the tooltip, so it should match the option imo.

Not sure I get it, but as I said it's fine as it is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename document access "None" to "No restrictions"
3 participants