New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename "none" document access to "no restrictions" #1138
base: main
Are you sure you want to change the base?
chore: rename "none" document access to "no restrictions" #1138
Conversation
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@raikasdev is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey! We like the wording with "Anyone with the link" but from a users perspective it might be confusing since to them it appears to just an email not a link Whereas Google Docs is an actual link you copy What do you think about "No Restrictions" instead? |
That's great also! Gonna edit the PR later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good
- The action authentication could say "No authentication" but that's a matter of taste I guess
It's in the tooltip, so it should match the option imo. |
Not sure I get it, but as I said it's fine as it is :) |
Description
Renames the "None" document access option to "Anyone with the link".
Related Issue
Fixes #1137
Changes Made
Testing Performed
Tested on my local envinronment. Well, it's only changing a label and a tooltip text 😄
Checklist