New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove the existing empty signer if its the only one #1127
base: main
Are you sure you want to change the base?
Conversation
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect this to fill the first empty field found
Screen.Recording.2024-04-29.at.8.25.02.pm.mov
Also some bugs
Screen.Recording.2024-04-29.at.8.26.24.pm.mov
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
@dguyen Regarding the bug, we only save the information of the signer if we click But if its needed to have a condition to check if the fields are filled and if so, add a new entry, I would be glad to change it to that one 👀 |
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
I'm not sure what you mean, adding yourself obviously should not override other recipients. |
@dguyen Gotcha, I will update the conditions to reflect the same |
…at/start-selfSign
…cumenso into feat/start-selfSign
Signed-off-by: Adithya Krishna <aadithya794@gmail.com>
Description:
This PR removes the existing empty signer if its the only one