feat: show time in documents table #1123

rushatgabhane · 2024-04-28T23:01:57Z

name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Display time in 12h format in the documents table.

Related Issue

Fixes #1077

Changes Made

Use DateTime.DATETIME_SHORT
...

Testing Performed

Tested time in different timezone.
Ran tests in web and mobile browser

Login
Add a document
Verify that you see date and time in 12h format as per your locale.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

vercel · 2024-04-28T23:02:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stg-docs	❌ Failed (Inspect)			May 21, 2024 8:49am

coderabbitai · 2024-04-28T23:02:02Z

Important

Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2024-04-28T23:02:03Z

@rushatgabhane is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2024-04-28T23:02:10Z

Hey There! and thank you for opening this pull request! 📝👋🏼

We require pull request titles to follow the Conventional Commits Spec and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Feat" found in pull request title "Feat: show time in documents table". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Mythie · 2024-04-28T23:02:59Z

Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA:

https://documen.so/cla

rushatgabhane · 2024-04-28T23:04:12Z

CLA signed. Please re-run

adithyaakrishna · 2024-05-08T09:53:52Z

apps/web/src/app/(dashboard)/documents/data-table.tsx

@@ -62,7 +63,9 @@ export const DocumentsDataTable = ({
          {
            header: 'Created',
            accessorKey: 'createdAt',
-            cell: ({ row }) => <LocaleDate date={row.original.createdAt} />,
+            cell: ({ row }) => (
+              <LocaleDate date={row.original.createdAt} format={DateTime.DATETIME_SHORT} />


Tested it locally and LGTM

Date comes in 12hr format

Is in line with our Timestamp design according to our design file

Checked it on mobile as well

ElTimuro · 2024-05-08T12:20:40Z

@rushatgabhane For Germany, I'm getting a 24-hour format. Is this by design, since Germany does not have a 12-hour format?

adithyaakrishna · 2024-05-08T12:32:33Z

@ElTimuro AFAIK this might be the luxon library doing its thing, we can also have a specific format MM/dd/yyyy, hh:mm a for it

ElTimuro · 2024-05-08T13:01:02Z

Since we are not localizing yet, we should keep it consistent, I think

rushatgabhane · 2024-05-08T13:20:57Z

Makes sense. Let me make the change to be 12h

rushatgabhane · 2024-05-08T13:48:54Z

@ElTimuro done! Ready for re-review @adithyaakrishna

adithyaakrishna

Checked it and works fine now :)

@ElTimuro, could you pls confirm the same as well?

ElTimuro

Checked locally
Looks good, merging

feat: show time in documents table

80c03fc

github-actions bot added the apps: web Issues related to the webapp label Apr 28, 2024

vercel bot had a problem deploying to Preview – stg-docs April 28, 2024 23:02 Failure

rushatgabhane changed the title ~~Feat: show time in documents table~~ feat: show time in documents table Apr 28, 2024

rushatgabhane closed this Apr 28, 2024

rushatgabhane reopened this Apr 28, 2024

rushatgabhane mentioned this pull request Apr 28, 2024

Adding time to the document table #1077

Closed

6 tasks

Merge branch 'main' into show-time

dca4b8e

vercel bot had a problem deploying to Preview – stg-docs April 30, 2024 04:01 Failure

Merge branch 'main' into show-time

84bbcea

vercel bot had a problem deploying to Preview – stg-docs May 3, 2024 06:59 Failure

adithyaakrishna previously approved these changes May 8, 2024

View reviewed changes

Merge branch 'main' into show-time

968b116

vercel bot had a problem deploying to Preview – stg-docs May 8, 2024 09:57 Failure

feat: 12h format

bbcbc56

rushatgabhane dismissed adithyaakrishna’s stale review via bbcbc56 May 8, 2024 13:48

vercel bot had a problem deploying to Preview – stg-docs May 8, 2024 13:48 Failure

Merge branch 'main' into show-time

788933b

rushatgabhane requested a review from adithyaakrishna May 8, 2024 13:48

vercel bot had a problem deploying to Preview – stg-docs May 8, 2024 13:48 Failure

adithyaakrishna approved these changes May 8, 2024

View reviewed changes

Merge branch 'main' into show-time

a877c64

vercel bot had a problem deploying to Preview – stg-docs May 12, 2024 15:37 Failure

Merge branch 'main' into show-time

e072e27

vercel bot had a problem deploying to Preview – stg-docs May 21, 2024 08:49 Failure

ElTimuro self-requested a review May 21, 2024 12:10

ElTimuro approved these changes May 21, 2024

View reviewed changes

ElTimuro merged commit 24b228a into documenso:main May 21, 2024
4 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: show time in documents table #1123

feat: show time in documents table #1123

rushatgabhane commented Apr 28, 2024 •

edited

vercel bot commented Apr 28, 2024 •

edited

coderabbitai bot commented Apr 28, 2024 •

edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

vercel bot commented Apr 28, 2024

github-actions bot commented Apr 28, 2024

Mythie commented Apr 28, 2024

rushatgabhane commented Apr 28, 2024

adithyaakrishna May 8, 2024 •

edited

ElTimuro commented May 8, 2024

adithyaakrishna commented May 8, 2024

ElTimuro commented May 8, 2024

rushatgabhane commented May 8, 2024

rushatgabhane commented May 8, 2024

adithyaakrishna left a comment

ElTimuro left a comment •

edited

feat: show time in documents table #1123

feat: show time in documents table #1123

Conversation

rushatgabhane commented Apr 28, 2024 • edited

name: Pull Request about: Submit changes to the project for review and inclusion

Description

Related Issue

Changes Made

Testing Performed

Checklist

Additional Notes

vercel bot commented Apr 28, 2024 • edited

coderabbitai bot commented Apr 28, 2024 • edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

vercel bot commented Apr 28, 2024

github-actions bot commented Apr 28, 2024

Mythie commented Apr 28, 2024

rushatgabhane commented Apr 28, 2024

adithyaakrishna May 8, 2024 • edited

Choose a reason for hiding this comment

ElTimuro commented May 8, 2024

adithyaakrishna commented May 8, 2024

ElTimuro commented May 8, 2024

rushatgabhane commented May 8, 2024

rushatgabhane commented May 8, 2024

adithyaakrishna left a comment

Choose a reason for hiding this comment

ElTimuro left a comment • edited

Choose a reason for hiding this comment

rushatgabhane commented Apr 28, 2024 •

edited

name: Pull Request
about: Submit changes to the project for review and inclusion

vercel bot commented Apr 28, 2024 •

edited

coderabbitai bot commented Apr 28, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

adithyaakrishna May 8, 2024 •

edited

ElTimuro left a comment •

edited