Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signatures to be created from an image #765

Open
5 tasks done
wendellli99 opened this issue Dec 16, 2023 · 24 comments · May be fixed by #905
Open
5 tasks done

Allow signatures to be created from an image #765

wendellli99 opened this issue Dec 16, 2023 · 24 comments · May be fixed by #905
Assignees
Labels
apps: web Issues related to the webapp community Community-handled PRs or issues requiring guidance from core team Stale type: enhancement Enhancing a existing feature type: feature New feature or request

Comments

@wendellli99
Copy link

Feature Description

DocuSign allows signatures to be created from an image. I wish documenso can also support this feature.
https://support.docusign.com/s/document-item?language=en_US&bundleId=jux1643235969954&topicId=xmt1578456441423.html&_LANG=enus

Use Case

No response

Proposed Solution

No response

Alternatives (optional)

No response

Additional Context

No response

Please check the boxes that apply to this feature request.

  • I have searched the existing feature requests to make sure this is not a duplicate.
  • I have provided a detailed description of the requested feature.
  • I have explained the use case or scenario for this feature.
  • I have included any relevant technical details or design suggestions.
  • I understand that this is a suggestion and that there is no guarantee of implementation.
@github-actions github-actions bot added the status: triage Scope to be determined label Dec 16, 2023
Copy link

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@catalinpit
Copy link
Contributor

Thanks for the suggestion, @wendellli99! Sounds like a useful idea. I'm not sure where this lands in our list of priorities, but if anyone wants to pick it in the meantime, please let me know! 🙏

@catalinpit catalinpit added type: enhancement Enhancing a existing feature type: feature New feature or request community Community-handled PRs or issues requiring guidance from core team apps: web Issues related to the webapp and removed status: triage Scope to be determined labels Dec 19, 2023
@Dun-sin
Copy link

Dun-sin commented Dec 19, 2023

@catalinpit can i give this a try?

@catalinpit
Copy link
Contributor

Hey @Dun-sin, sure! I'm assigning it to you. Thanks!

@harkiratsm
Copy link
Contributor

Quick check-in: Any updates on the task? // @Dun-sin

@Dun-sin
Copy link

Dun-sin commented Dec 24, 2023

Quick check-in: Any updates on the task? // @Dun-sin

none atm, i had a little accident so had to stay away from my computer for a while, but i'm getting back on it, may be slow tho because of the holidays

@Dun-sin
Copy link

Dun-sin commented Dec 24, 2023

Here's what I plan to do for this issue, let me know if it fits right into your vision @wendellli99 and if it's okay to go ahead with it @catalinpit.

What I understand this issue to do, it seems it aims to add a way to use images as signatures instead of always drawing right @wendellli99?

Does this also mean we store the images too, like we do the ones we draw?
Can you have more than one image that user can select from?
Will storing more than one image be a premium feature?

anything else you have in mind, pls let me know

@wendellli99
Copy link
Author

@Dun-sin Thank you for taking the initiative. What I was looking for is a replica of DocuSign's feature that makes it possible to create a signature from an image.

Does this also mean we store the images too, like we do the ones we draw?

I believe we only need to store the signature extracted from that image, not the original image.

Can you have more than one image that user can select from?

I think it's useful to allow users to store signatures, even those hand-drawn ones.

Will storing more than one image be a premium feature?

It's up to @catalinpit 😄

@Dun-sin
Copy link

Dun-sin commented Dec 25, 2023

@Dun-sin Thank you for taking the initiative. What I was looking for is a replica of DocuSign's feature that makes it possible to create a signature from an image.

Does this also mean we store the images too, like we do the ones we draw?

I believe we only need to store the signature extracted from that image, not the original image.

Can you have more than one image that user can select from?

I think it's useful to allow users to store signatures, even those hand-drawn ones.

Will storing more than one image be a premium feature?

It's up to @catalinpit 😄

can i have a demo on how docusign does it?

@wendellli99
Copy link
Author

@Dun-sin Here's a screenshot.
Screenshot 2023-12-25 at 01 04 15

@Dun-sin
Copy link

Dun-sin commented Dec 25, 2023

@Dun-sin Here's a screenshot. Screenshot 2023-12-25 at 01 04 15

thanks for the demo, is this feature free on docusign?

@wendellli99
Copy link
Author

wendellli99 commented Dec 25, 2023

@Dun-sin Here's a screenshot. Screenshot 2023-12-25 at 01 04 15

thanks for the demo, is this feature free on docusign?

It was free. There's no additional charge. You do have to be a paid member to use DocuSign nowadays.

@Dun-sin
Copy link

Dun-sin commented Dec 25, 2023

@Dun-sin Here's a screenshot. Screenshot 2023-12-25 at 01 04 15

thanks for the demo, is this feature free on docusign?

It was free. There's no additional charge. You do have to be a paid member to use DocuSign nowadays.

Sucks, wanted to really test the mechanics they use

@harkiratsm
Copy link
Contributor

Are you currently working on this? If not, I can take it on. // @Dun-sin

@Dun-sin
Copy link

Dun-sin commented Dec 29, 2023

Are you currently working on this? If not, I can take it on. // @Dun-sin

i'm working on it, but if you would like to collab on it, we can, let me know if you want to

@harkiratsm
Copy link
Contributor

Sure, go ahead! Let me know if you need any help.

@Dun-sin
Copy link

Dun-sin commented Dec 31, 2023

Sure, go ahead! Let me know if you need any help.

Awesome, let me know how I can contact you

@Dun-sin
Copy link

Dun-sin commented Jan 5, 2024

@harkiratsm you can have this issue, i still have alot to learn before i can properly contribute and i don't want to waste time, @catalinpit pls unassign me

@catalinpit catalinpit assigned harkiratsm and unassigned Dun-sin Jan 5, 2024
@adithyaakrishna
Copy link
Member

Hey @harkiratsm, could you pls let us know if you have any update on this issue?

@harkiratsm
Copy link
Contributor

I've started working on this and will submit a pr this week. // @adithyaakrishna @Mythie

@adithyaakrishna
Copy link
Member

Awesome! Looking forward to seeing your PR 🚀

@harkiratsm harkiratsm linked a pull request Feb 5, 2024 that will close this issue
@ElTimuro
Copy link
Member

@harkiratsm are you still working on this? :)

@harkiratsm
Copy link
Contributor

@ElTimuro I've made a PR, awaiting review.

@ElTimuro ElTimuro linked a pull request Feb 14, 2024 that will close this issue
@ElTimuro
Copy link
Member

  • @harkiratsm awesome, did not see it.
  • Linked here for visibiltly
  • Review coming soon™️

@github-actions github-actions bot added the Stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp community Community-handled PRs or issues requiring guidance from core team Stale type: enhancement Enhancing a existing feature type: feature New feature or request
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants