Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time to the document table #1077

Closed
1 of 6 tasks
kodermax opened this issue Apr 4, 2024 · 3 comments · Fixed by #1123
Closed
1 of 6 tasks

Adding time to the document table #1077

kodermax opened this issue Apr 4, 2024 · 3 comments · Fixed by #1123
Assignees
Labels
component: ui User interface changes effort: low Issues which are low effort or easy priority: low Low priority issue status: assigned Issue has been assigned

Comments

@kodermax
Copy link

kodermax commented Apr 4, 2024

Feature Description

I suggest adding the time information to the document table.

image

Use Case

No response

Proposed Solution

No response

Alternatives (optional)

No response

Additional Context

No response

Please check the boxes that apply to this feature request.

  • I have searched the existing feature requests to make sure this is not a duplicate.
  • I have provided a detailed description of the requested feature.
  • I have explained the use case or scenario for this feature.
  • I have included any relevant technical details or design suggestions.
  • I understand that this is a suggestion and that there is no guarantee of implementation.
  • I want to work on creating a PR for this issue if approved
@rushatgabhane
Copy link
Contributor

hey, i would like to work on this if this feature is accepted

@ElTimuro
Copy link
Member

@rushatgabhane makes sense, you got it

@rushatgabhane
Copy link
Contributor

PR is up! #1123

@adithyaakrishna adithyaakrishna added status: assigned Issue has been assigned component: ui User interface changes priority: low Low priority issue effort: low Issues which are low effort or easy and removed needs triage labels May 8, 2024
ElTimuro added a commit that referenced this issue May 21, 2024
---
name: Pull Request
about: Submit changes to the project for review and inclusion
---

## Description

Display time in 12h format in the documents table.
<!--- Describe the changes introduced by this pull request. -->
<!--- Explain what problem it solves or what feature/fix it adds. -->

## Related Issue

<!--- If this pull request is related to a specific issue, reference it
here using #issue_number. -->
<!--- For example, "Fixes #123" or "Addresses #456". -->
Fixes #1077 
## Changes Made

<!--- Provide a summary of the changes made in this pull request. -->
<!--- Include any relevant technical details or architecture changes.
-->

- Use DateTime.DATETIME_SHORT
- ...

## Testing Performed

<!--- Describe the testing that you have performed to validate these
changes. -->
<!--- Include information about test cases, testing environments, and
results. -->

- Tested time in different timezone.
- Ran tests in web and mobile browser

1. Login 
2. Add a document
3. Verify that you see date and time in 12h format as per your locale.

## Checklist

<!--- Please check the boxes that apply to this pull request. -->
<!--- You can add or remove items as needed. -->

- [x] I have tested these changes locally and they work as expected.
- [x] I have added/updated tests that prove the effectiveness of these
changes.
- [x] I have updated the documentation to reflect these changes, if
applicable.
- [x] I have followed the project's coding style guidelines.
- [x] I have addressed the code review feedback from the previous
submission, if applicable.

## Additional Notes
<img width="1512" alt="Screenshot 2024-04-29 at 04 21 53"
src="https://github.com/documenso/documenso/assets/29673073/778155d4-a920-40bd-acdc-7451c9c5d4b7">


<img width="300" alt="Screenshot 2024-04-29 at 04 22 18"
src="https://github.com/documenso/documenso/assets/29673073/3471de0f-f426-4ea1-be1e-220462aff9e4">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui User interface changes effort: low Issues which are low effort or easy priority: low Low priority issue status: assigned Issue has been assigned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants