Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Add a differentiator to the teams in Profile Dropdown #943

Closed
5 tasks done
sumitbishti opened this issue Feb 16, 2024 · 4 comments · Fixed by #1122
Closed
5 tasks done

[Improvement] Add a differentiator to the teams in Profile Dropdown #943

sumitbishti opened this issue Feb 16, 2024 · 4 comments · Fixed by #1122
Assignees
@sumitbishti
Labels
apps: web Issues related to the webapp component: ui User interface changes Stale status: assigned Issue has been assigned

Comments

@sumitbishti
Copy link
Contributor

sumitbishti commented Feb 16, 2024 •
edited

Describe the improvement you are suggesting in detail

If we allow to create multiple teams with the same name. Then how are we supposed to differentiate btw them in the profile dropdown?

image

Additional Information & Alternatives (optional)

We should either have unique team names
or
We should also show the team url in a team item box in dropdown.
something like this:

sum (owner)
localhost:3000/t/sume

sum (owner)
localhost:3000/t/notsume

Do you want to work on this improvement?

Yes

Please check the boxes that apply to this improvement suggestion.

  • I have searched the existing issues and improvement suggestions to avoid duplication.
  • I have provided a clear description of the improvement being suggested.
  • I have explained the rationale behind this improvement.
  • I have included any relevant technical details or design suggestions.
  • I understand that this is a suggestion and that there is no guarantee of implementation.
@github-actions github-actions bot added the status: triage Scope to be determined label Feb 16, 2024
@dguyen
Copy link
Collaborator

dguyen commented Feb 17, 2024

Oh, we had a design for this I think. I just forgot to implement it.

When you hover over the element, it should change the team role to the team url with a fade in/out animation.

@dguyen dguyen added status: assigned Issue has been assigned apps: web Issues related to the webapp component: ui User interface changes and removed status: triage Scope to be determined labels Feb 17, 2024
@sumitbishti
Copy link
Contributor Author

sumitbishti commented Feb 17, 2024 •
edited

Ok let me implement it then, would raise a PR soon.

@sumitbishti
Copy link
Contributor Author

sumitbishti commented Feb 17, 2024 •
edited

Oh, we had a design for this I think. I just forgot to implement it.

When you hover over the element, it should change the team role to the team url with a fade in/out animation.

Should fade in/out be just for the team url or the whole item?

@dguyen
Copy link
Collaborator

dguyen commented Feb 18, 2024

Probably just the team url

@sumitbishti sumitbishti mentioned this issue Feb 20, 2024
Closed
@sumitbishti sumitbishti mentioned this issue Apr 28, 2024
Merged
@github-actions github-actions bot added the Stale label May 18, 2024
Mythie added a commit that referenced this issue May 24, 2024
@Mythie
fix: show team url in dropdown menu on hover (#1122)
94cf412 
fixes: #943 

<img width="330" alt="Screenshot 2024-02-19 211732"
src="https://github.com/documenso/documenso/assets/75713174/724078ca-e107-4acb-a75d-c7d2cdd29b80">


Video Link:
https://www.loom.com/share/35328504cf3f46e9be78bd485252e8dc?sid=1f309776-8b52-4af4-b86b-652b762fef5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumitbishti sumitbishti

Labels
apps: web Issues related to the webapp component: ui User interface changes Stale status: assigned Issue has been assigned
Projects
None yet
Milestone
No milestone
2 participants
@dguyen @sumitbishti