Fix deprecation layer of Doctrine\ORM\ORMException #11430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W0rma
changed the title
W0rma
force-pushed
the
fix-deprecation-layer-orm-exception
branch
from
fdaee30
to
20b0912
Compare
W0rma
force-pushed
the
fix-deprecation-layer-orm-exception
branch
2 times, most recently
from
6458c46
to
d0e5966
Compare
W0rma
force-pushed
the
fix-deprecation-layer-orm-exception
branch
from
d0e5966
to
ad5c8e4
Compare
|
This PR also fixes PHP 7.1 compatibility of the test added in #11428 - this was necessary to make the CI green. Please let me know if you prefer a dedicated PR for this change. |
greg0ire
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11244
This PR starts using the new exception classes introduced by #8692 in
Doctrine\ORM\ORMException.This way it is ensured that the thrown exception is an instance of
Doctrine\ORM\ORMException(= deprecated) andDoctrine\ORM\Exception\ORMException(= not deprecated).